feat(error-handling): adapt code to the new system#752
Open
TheMaskedTurtle wants to merge 3 commits intomainfrom
Open
feat(error-handling): adapt code to the new system#752TheMaskedTurtle wants to merge 3 commits intomainfrom
TheMaskedTurtle wants to merge 3 commits intomainfrom
Conversation
Signed-off-by: Joris Mancini <joris.mancini_externe@rte-france.com>
Signed-off-by: Joris Mancini <joris.mancini_externe@rte-france.com>
|
Meklo
reviewed
Jan 8, 2026
| } catch (JsonProcessingException error) { | ||
| throw new PowsyblException("error creating report", error); | ||
| } | ||
| reportServerRest.exchange(this.getReportServerURI() + path, HttpMethod.PUT, new HttpEntity<>(reportNode, headers), ReportNode.class); |
Contributor
There was a problem hiding this comment.
objectMapper has no other use so it can be safely removed I reckon
Meklo
reviewed
Jan 8, 2026
| assertEquals("LOAD_FLOW_PARAMETERS_FETCH_ERROR : Internal server error", exception.getMessage()); | ||
| } | ||
|
|
||
| /** |
Contributor
There was a problem hiding this comment.
I suppose testGetLoadFlowParametersInfosServerError just above and the mock setup for LOAD_FLOW_PARAMETERS_FETCH_ERROR in the @BeforeEach function may also be removed
Contributor
There was a problem hiding this comment.
Which would enable removing LOAD_FLOW_PARAMETERS_FETCH_ERROR from NetworkModificationException
Signed-off-by: Joris Mancini <joris.mancini_externe@rte-france.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Use new BaseExceptionHandler from powsybl-ws-commons and adapt the code to the new good practices about error-handling