Merged
Conversation
Signed-off-by: basseche <bassel.el-cheikh_externe@rte-france.com>
… creation and modification)
Signed-off-by: basseche <bassel.el-cheikh_externe@rte-france.com>
basseche
force-pushed
the
check_power_values
branch
from
89d31fb to
86c8d10
Compare
ghazwarhili
reviewed
Feb 10, 2026
| double minP = modificationInfos.getMinP() != null ? modificationInfos.getMinP().getValue() : generator.getMinP(); | ||
| double maxP = modificationInfos.getMaxP() != null ? modificationInfos.getMaxP().getValue() : generator.getMaxP(); | ||
| double targetP = modificationInfos.getTargetP() != null ? modificationInfos.getTargetP().getValue() : generator.getTargetP(); | ||
| Double pImp = modificationInfos.getPlannedActivePowerSetPoint() != null ? modificationInfos.getPlannedActivePowerSetPoint().applyModification(oldValue) : null; |
Contributor
There was a problem hiding this comment.
plannedActivePowerSetpoint is better than pImp ?
ghazwarhili
reviewed
Feb 10, 2026
|
|
||
| public static void checkPowerValues(String errorMessage, double minP, double maxP, double targetP, Double pImp, NetworkModificationException.Type exceptionType) throws NetworkModificationException { | ||
| checkActivePowerValue(errorMessage, FIELD_ACTIVE_POWER_TARGET, targetP, minP, maxP, exceptionType); | ||
| if (pImp != null) { |
Contributor
There was a problem hiding this comment.
why this check ?
we have already if (modificationInfos.getPlannedActivePowerSetPoint() != null)
Contributor
Author
There was a problem hiding this comment.
it is not for the same function
ghazwarhili
approved these changes
Feb 11, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Add check for massive modification on power values to respect :
Pmin < PImp< Pmax & Pmin< PCons < Pmax
concerned modifications