refacto: make async persisting logic more readable and maintainable #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GhilesA
force-pushed
the
refacto/improve_persisted_poller_code
branch
5 times, most recently
from
d1ebce7 to
21a74d9
Compare
GhilesA
force-pushed
the
refacto/improve_persisted_poller_code
branch
from
21a74d9 to
f339863
Compare
jonenst
reviewed
Feb 3, 2026
...java/org/gridsuite/sensitivityanalysis/server/util/SensitivityResultPersistedWriterTest.java
Outdated
Show resolved
Hide resolved
jonenst
reviewed
Feb 3, 2026
src/test/java/org/gridsuite/sensitivityanalysis/server/util/BatchAsyncPollerTest.java
Outdated
Show resolved
Hide resolved
jonenst
reviewed
Feb 3, 2026
src/main/java/org/gridsuite/sensitivityanalysis/server/util/ExecutorProviderService.java
Outdated
Show resolved
Hide resolved
jonenst
reviewed
Feb 5, 2026
src/main/java/org/gridsuite/sensitivityanalysis/server/util/BatchAsyncPoller.java
Outdated
Show resolved
Hide resolved
jonenst
reviewed
Feb 5, 2026
src/main/java/org/gridsuite/sensitivityanalysis/server/util/BatchAsyncPoller.java
Outdated
Show resolved
Hide resolved
GhilesA
force-pushed
the
refacto/improve_persisted_poller_code
branch
4 times, most recently
from
93b2b4f to
48a00c7
Compare
GhilesA
force-pushed
the
refacto/improve_persisted_poller_code
branch
from
48a00c7 to
b52e8d9
Compare
use a ScheduledExecutorService to handle the background periodic logic safely cancel, wait for completion and close the threads and executor using its api remove Thread::sleep from the code
GhilesA
force-pushed
the
refacto/improve_persisted_poller_code
branch
from
b52e8d9 to
37de559
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
use a ScheduledExecutorService to handle the background periodic logic safely cancel, wait for completion and close the threads and executor using its api
remove Thread::sleep from the code
@jonenst some questions are still remaining, can you provide some background info on the TODOs and FIXME ?