-
Notifications
You must be signed in to change notification settings - Fork 533
Support for ARM, updated PDFAlto, Docker multi-architecture build #1165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
I'm getting when trying to run on macos m1 |
|
@heijligers which image did you try? This one was correctly built with multi arch and arm support: My next step was to try to solve this issue with spawning process by looking on a way to have a conditional decision in the Dockerfile Any help is welcome for this issue 🙂 |
|
I am currently working on this for the default CRF Docker (Docker.crf) . This needs work :-
There seems a number of libraries involved :-
tinihttps://github.com/krallin/tini pdfaltohttps://github.com/kermitt2/pdfalto libwapitihttps://github.com/kermitt2/wapiti libcrfpphttps://github.com/taku910/crfpp/ libjephttps://github.com/ninia/jep I will update this comment as a tracking comment as I make progress. |
|
@lfoppiano It seems the way to deal with multi platform and multi architecture OS/ARCH builds is with build and buildx :- https://github.com/docker/buildx?tab=readme-ov-file#building-multi-platform-images This should work across multiple docker images :- |
|
@AaronNGray yes, this is what I believe I did to build the image with github actions, however I did not succeed in having a running docker image for Apple M1. |
a2d0283 to
49e9166
Compare
|
Good going. I posted some stuff to check regarding ABI's and compilers on Grobid-core Discord, it maybe obvious but may need checking. |
9cb10e5 to
9a60975
Compare
6777a6a to
933f01c
Compare
…ky-openjdk-24-gradle-8.14.2 Update to Ubuntu Plucky, OpenJDK/JRE 24, and Gradle 8.14.2
# Conflicts: # .github/workflows/ci-build-manual-crf.yml # .github/workflows/ci-build-unstable.yml # Dockerfile.crf # Dockerfile.delft # build.gradle # gradle/wrapper/gradle-wrapper.properties
Pull Request Test Coverage Report for Build 21920119213Details
💛 - Coveralls |
…multi-arch-docker-image
1b77d7d to
797d1e9
Compare
|
macos-13 is no longer supported by GitHub build system. |
|
I know, I've fixed in both pdfalto and wapiti, and here! :-) |
Finally I nailed it!
This PR provide a multi-architecture build for amd64/arm64. I've switched to the eclipse-adoptium-17-jdk/jre but, for the moment, I'm using ubuntu 20.04 (focal) instead of ubuntu 22. For now Is limited to the manual build for the CRF only image.
This requires some tests,
here herehere the resulting image.This PR should help to solve #1089, #928, #1014, #1119
Update: At the moment the ARM support for the Deep Learning image is not working natively because there is no
linux/arm64docker image of the base images (even oftensorflow/tensorflow:2.17.0)