Skip to content

Conversation

@jbagot
Copy link

@jbagot jbagot commented Dec 16, 2025

I added a new feature that sync the jamf buildings to snipe. It works fine if the locations are created in snipe it, but there are some work to do.

Things to do

  1. Create buildings on the fly when they don't exist in snipe it.
  2. Create some args to activate or deactivate the feature.
  3. Clean the code a bit to create something more scalable.

The PR has 2 commits, one for commit and other with the new feature. The format is an automatic format of Black.

@jerm
Copy link
Member

jerm commented Dec 17, 2025

@jbagot Thanks for working on this!

I know it's still a WIP, but I'd like to request that you pull-out the formatting changes, and submit those as a separate PR, so we can evaluate your functional changes separately from the diff so long that github won't display it by default ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants