Skip to content

Conversation

@uberbrady
Copy link
Member

So the line that we're attempting to put guardrails around is the one that we've been seeing tons of on Rollbar. It has to do with some level of SCIM misconfiguration - I think when a user tries to map a 'subtype' that we don't handle of something that we do handle - for example, we do handle phone numbers, but we don't handle Fax numbers. So I think this exception is what we get when someone sends us one of those unhandled subtypes.

I deliberately tried to keep the change small - since it's hard to test. I also figure that since we're already 500'ing on these, if I did screw anything up, it wouldn't be any worse than we are already doing.

I stole some of the syntax from how the upstream author did similar errors -

throw (new SCIMException(sprintf('Unknown attribute "%s"', $scimAttribute)))->setCode(400);

But changed the verbiage slightly so that we could, hopefully, better differentiate when the errors come from this message versus that one.

If we do decide to integrate this change, we will need to change the branch that we're pointing to from Snipe-IT, as well doing a selective composer update to make sure to pull the latest corrected version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants