Conversation
gropaul
pushed a commit
that referenced
this pull request
Nov 7, 2025
…al get function is an unnest (duckdb#19467) The issue is caused by a very specific plan where a logical get (that has an unnest function) is the direct child of a logical comparison join. Normally for logical gets, we only add the one table index to the set of table indexes that can be joined on. However, if the logical get has an unnest function and there are children, the table indexes of those children can also be joined on. The Join Order Optimizer did not consider this case, which also turns out to be extremely rare. Here is the plan before the join order optimizer gets to it. I tried to write another test case but struggled for about 30 min. ``` ┌───────────────────────────┐ │ PROJECTION #23 │ │ ──────────────────── │ │ Expressions: │ │ #[0.0] (VARCHAR[]) │ │ #[0.1] (VARCHAR) │ │ #[0.2] (INTEGER) │ │ #[0.3] (VARCHAR) │ │ #[0.4] (VARCHAR) │ │ #[8.0] (VARCHAR) │ │ #[17.0] (JSON) │ └─────────────┬─────────────┘ ┌─────────────┴─────────────┐ │ DELIM_JOIN │ │ ──────────────────── │ │ Join Type: INNER │ │ ├──────────────┐ │ Conditions: │ │ │ (#[29.0] IS NOT DISTINCT │ │ │ FROM #[2.1]) │ │ └─────────────┬─────────────┘ │ ┌─────────────┴─────────────┐┌─────────────┴─────────────┐ │ WINDOW #29 ││ COMPARISON_JOIN │ │ ──────────────────── ││ ──────────────────── │ │ Expressions: ││ Join Type: INNER │ │ ROW_NUMBER() OVER (ROWS ││ │ │ BETWEEN UNBOUNDED ││ Conditions: │ │ PRECEDING AND CURRENT ROW)││ (#[2.1] IS NOT DISTINCT ├──────────────┐ │ ││ FROM #[17.1]) │ │ │ ││ (#[2.2] IS NOT DISTINCT │ │ │ ││ FROM #[17.2]) │ │ │ ││ (#[2.3] IS NOT DISTINCT │ │ │ ││ FROM #[17.3]) │ │ └─────────────┬─────────────┘└─────────────┬─────────────┘ │ ┌─────────────┴─────────────┐┌─────────────┴─────────────┐┌─────────────┴─────────────┐ │ SEQ_SCAN #0 ││ UNNEST #8 ││ PROJECTION #17 │ │ ──────────────────── ││ ──────────────────── ││ ──────────────────── │ │ Table: xxxxxxxxxxxxxx ││ ││ Expressions: │ │ Type: Sequential Scan ││ ││ #[16.1] (JSON) │ │ ││ ││ #[10.1] (BIGINT) │ │ ││ ││ #[10.2] (VARCHAR) │ │ ││ ││ #[10.3] (VARCHAR[]) │ └───────────────────────────┘└─────────────┬─────────────┘└─────────────┬─────────────┘ ┌─────────────┴─────────────┐┌─────────────┴─────────────┐ │ PROJECTION #2 ││ JSON_EACH #16 │ │ ──────────────────── ││ ──────────────────── │ │ Expressions: ││ │ │ #[30.2] (VARCHAR[]) ││ │ │ #[30.0] (BIGINT) ││ │ │ #[30.1] (VARCHAR) ││ │ │ #[30.2] (VARCHAR[]) ││ │ └─────────────┬─────────────┘└─────────────┬─────────────┘ ┌─────────────┴─────────────┐┌─────────────┴─────────────┐ │ DELIM_GET #30 ││ PROJECTION #10 │ │ ──────────────────── ││ ──────────────────── │ │ ││ Expressions: │ │ ││ #[31.1] (VARCHAR) │ │ ││ #[31.0] (BIGINT) │ │ ││ #[31.1] (VARCHAR) │ │ ││ #[31.2] (VARCHAR[]) │ └───────────────────────────┘└─────────────┬─────────────┘ ┌─────────────┴─────────────┐ │ DELIM_GET #31 │ │ ──────────────────── │ └───────────────────────────┘ ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.