Skip to content

Conversation

@fisayoadabs
Copy link

No description provided.

@abarcomb-work
Copy link
Collaborator

Pull requests should contain useful information about the reasoning behind the changes for the repository maintainer to enable them to prioritize PRs. This is part of the collaborative workflow.

@abarcomb-work
Copy link
Collaborator

The PR should have been made to the ensf400-ws24 branch, not to main.

@growlf growlf self-assigned this Feb 25, 2024
Copy link
Owner

@growlf growlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace the lines in the docker-compose.yml file - they are needed for using this image as a development tool.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good changes!!

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change will actually remove useful code. Please look at the other service definitions in this file.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is from an existing branch and is not needed here - once that branch is merged.

Comment on lines -16 to -18
- ${HOME}/.gitconfig:/home/ubuntu/.gitconfig
- ${HOME}/.ssh:/home/ubuntu/.ssh
- ${PWD}:/app
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for local credentials and allows development entirely within the safety of the container.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants