A108: OpenTelemetry Custom Per-Call Metric Label #525
Conversation
|
|
||
| ### Go | ||
|
|
||
| gRPC Go will add a new API to set and get the custom label value in |
|
|
||
| ### C++ | ||
|
|
||
| gRPC C++ will add an API to ClientContext. Precise details TBD. |
There was a problem hiding this comment.
@markdroth, can you help me flesh this out? It looks like y'all will need specialized APIs/plumbing.
There was a problem hiding this comment.
I'll chat with @ctiller after the holidays to flesh this out, and I'll get back to you.
|
CC @ctiller |
| * `grpc.client.call.retry_delay` | ||
| * Other per-call instruments, e.g., those added by an LB policy, are encouraged | ||
| to support this label | ||
| * RLS is the only such case today, but is not defined in a gRFC |
There was a problem hiding this comment.
I'd suggest just removing this bullet, since it isn't actually a public API. If we want this label on these metrics, we can figure that out internally.
|
|
||
| ### C++ | ||
|
|
||
| gRPC C++ will add an API to ClientContext. Precise details TBD. |
There was a problem hiding this comment.
I'll chat with @ctiller after the holidays to flesh this out, and I'll get back to you.
|
|
||
| ## Rationale | ||
|
|
||
| A single label is restrictive. We could allow applications to have multiple |
There was a problem hiding this comment.
Might also want to mention that supporting an arbitrary set of key/value pairs would likely impose some performance constraints that we'd prefer to avoid.
2 participants
No description provided.