Fix unique accessor bug #19
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that tests still pass with this change.
This causes tests to fail (which is what we want, before we fix this bug).
This reverts commit e4d66f53b21ce19466769cc067cc9eeaaf34a639. Note that the tests pass again.
This undoes the previous revert.
We need the ability to look up original column names from the accessor names. This allows the information to be cached for a form.
This fixes gshank#18 by using the column name instead of the accessor in the search condition.
Author
|
@gshank ? |
1 similar comment
Author
|
@gshank ? |
Author
|
It's been over two years since I submitted this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #18 by looking up the actual column from the accessor name for the search condition used to check uniqueness.