Rails3 automatically escaping render_audits#3
Open
vfilby wants to merge 1 commit intogtarnovan:masterfrom
vfilby:master
Open
Rails3 automatically escaping render_audits#3vfilby wants to merge 1 commit intogtarnovan:masterfrom vfilby:master
vfilby wants to merge 1 commit intogtarnovan:masterfrom
vfilby:master
Conversation
…ating the render_audits command was not enough because the changes were escape separately in the render_audits call. To make the audits render properly the changes have to be unescaped
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I am new to rails so there may be a much better way to handle this, but this seems to be working for me locally. If I use render_audits like this : raw( render_audits( @model ) ) it works mostly, but the actual delta changes are doubly escaped, so even with raw they are still escaped and not being included as HTML.
I found that if I encapsulated changes.join in the render_audits method it solved the problem. This might benefit other rails3 devs.
If there is a better way please do tell me, I am keen to learn more.
Also, your audit trails work really well, I like the rendered deltas as well, very slick.
Cheers,
Vince
vfilby@gmail.com