pulse_start_sample_index dataset in HDF5 files#6
Open
psychogenic wants to merge 1 commit intogtri:mainfrom
Open
pulse_start_sample_index dataset in HDF5 files#6psychogenic wants to merge 1 commit intogtri:mainfrom
psychogenic wants to merge 1 commit intogtri:mainfrom
Conversation
…capture-relative analysis (e.g. from a file source)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's much reliance on the actual time, which doesn't map well to analysis of capture files (e.g. using a File Source in GRC).
Without touching any of the other datasets, I've added a
pulse_start_sample_indexfield, which is just the offset of the sob.This allows me to have scripts running that line up with my offline investigation, like this:
While I was doing that, there was a lot of redundancy in the code, so I cleaned that up a bit.