Merged
Conversation
Added CSS for the NavBar to be fixed. It works both on PC and Mobile.
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://calm-sea-0d048991e-57.westus2.6.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://calm-sea-0d048991e-57.westus2.6.azurestaticapps.net |
hanrodz
requested changes
Nov 6, 2025
Member
hanrodz
left a comment
hanrodz
left a comment
There was a problem hiding this comment.
These changes look good but when navigating to the different sections the headers are cropped. The added spacing should be accounted for.
Not very familiar with the navigation bar implementation but I think the fix might be in or around layouts/App.tsx.
|
|
added scroll-padding-top. sync spacer height and z-index with global.css values
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://calm-sea-0d048991e-57.westus2.6.azurestaticapps.net |
Member
|
@Alfredcrmn feel free to merge as soon as the required checks succeed 😸 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The NavBar is now fixed, so when the user scrolls down, it remains at the top of the viewport.
Added a z-index of 1000 to ensure the NavBar stacks at the top of the page's elements.