Skip to content

Close mobile menu on navigation link click #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Close mobile menu on navigation link click #59

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22e7f0d
Initial plan
Copilot Nov 11, 2025
91e1cc3
Fix mobile menu not closing after navigation
Copilot Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions frontend/src/components/NavigationBar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,16 @@ const NavigationBar: React.FC = () => {
const [language, _] = languageState.useState();
const valeraClass = valeraLight.className;

const handleNavClick = () => {
setIsMenuOpen(false);
};

const navItems = (
const navItems = (isMobile: boolean = false) => (
<>
<Link href="/" className="text-lg hover:text-gray-400">{getLocalizedElement("navbar_home", language)}</Link>
<Link href="/#contact" className="text-lg hover:text-gray-400">{getLocalizedElement("navbar_contact", language)}</Link>
<Link href="/#partners" className="text-lg hover:text-gray-400">{getLocalizedElement("navbar_partners", language)}</Link>
<Link href="/#about" className="text-lg hover:text-gray-400">{getLocalizedElement("navbar_faq", language)}</Link>
<Link href="/" className="text-lg hover:text-gray-400" onClick={isMobile ? handleNavClick : undefined}>{getLocalizedElement("navbar_home", language)}</Link>
<Link href="/#contact" className="text-lg hover:text-gray-400" onClick={isMobile ? handleNavClick : undefined}>{getLocalizedElement("navbar_contact", language)}</Link>
<Link href="/#partners" className="text-lg hover:text-gray-400" onClick={isMobile ? handleNavClick : undefined}>{getLocalizedElement("navbar_partners", language)}</Link>
<Link href="/#about" className="text-lg hover:text-gray-400" onClick={isMobile ? handleNavClick : undefined}>{getLocalizedElement("navbar_faq", language)}</Link>
<LanguageToggle/>
</>
)
Expand Down Expand Up @@ -50,13 +53,13 @@ const NavigationBar: React.FC = () => {

{/* Navigation buttons */}
<div className={`flex items-center space-x-6 desktop-menu`}>
{navItems}
{navItems(false)}
</div>

{/* Mobile Sidebar */}
<div className={`mobile-menu ${isMenuOpen ? 'active' : ''}`}>
<span className="close-btn" onClick={() => setIsMenuOpen(false)}>×</span>
{navItems}
{navItems(true)}
{/*<span className="h-10 bg-transparent blank-reserve"></span>
<img src="./mlh-badge.svg" alt="MLH 2023 Hackathon Season" className="h-40 mlh-badge" />*/}
</div>
Expand Down