Skip to content
This repository was archived by the owner on Feb 5, 2026. It is now read-only.

Conversation

@Fweddi
Copy link
Contributor

@Fweddi Fweddi commented Sep 18, 2025

What does this change?

How to test

How can we measure success?

Have we considered potential risks?

Images

Accessibility

@rtyley
Copy link
Member

rtyley commented Sep 18, 2025

See #98 (comment) :

Currently we can't update the sbt-scrooge-typescript to 3.0.3 because the scrooge version in this library https://github.com/guardian/scrooge-extras/blob/main/build.sbt#L15C5-L15C19 bans some key words like end which is used on content-api-model thrift.

@Fweddi
Copy link
Contributor Author

Fweddi commented Sep 18, 2025

Closing this in favour of something that will better address the root cause of the original failure (https://github.com/guardian/apps-rendering-api-models/actions/runs/17826398067/job/50681372983) - this PR only causes more issues!

@Fweddi Fweddi closed this Sep 18, 2025
@Fweddi Fweddi mentioned this pull request Sep 18, 2025
@Fweddi Fweddi deleted the fp/bump-scrooge-typescript branch October 1, 2025 14:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants