Skip to content
This repository was archived by the owner on Feb 5, 2026. It is now read-only.

chore(deps): Guardian library updates #98

Closed
gu-scala-steward-public-repos wants to merge 1 commit into from
Closed

chore(deps): Guardian library updates #98

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import ReleaseTransformations._
import sbtversionpolicy.withsbtrelease.ReleaseVersion

val contentEntityVersion = "3.0.3"
val contentEntityVersion = "4.0.0"
Copy link
Contributor

@marjisound marjisound Jan 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently we can't update com.gu:content-entity-thrift to 4.0.0 because com.gu:content-api-models-scala depends on 3.0.3.

[error] 	* com.gu:content-entity-thrift:4.0.0 (early-semver) is selected over 3.0.3
[error] 	    +- com.gu:apps-rendering-api-models_2.13:10.0.1-SNAPSHOT (depends on 4.0.0)
[error] 	    +- com.gu:content-api-models-scala_2.13:26.0.0        (depends on 3.0.3)

More details:
The conflict seems to come from libthrift because content-entity-thrift in version 3.0.3 is using libthrift v0.19.0 but content-entity-thrift in version 4.0.0 is using libthrift v0.20.0

Resolution: We'd need content-api-models-scala to update their libthrift to 0.20.0 which seems to be already happening as part of this PR https://github.com/guardian/content-api-models/pull/249/files

val contentAtomVersion = "9.0.0"
val storyPackageVersion = "2.2.0"
val contentApiModelsVersion = "34.0.0"
Expand Down
Loading