Upgrade dynamo to use sdk v2 #133
Conversation
… lindseydew lindseydew published release version 8.0.0-PREVIEW.ldupgrade-dynamo.2025-12-02T1740.a6877dba using gha-scala-library-release-workflow: https://github.com/guardian/gha-scala-library-release-workflow Release-Version: 8.0.0-PREVIEW.ldupgrade-dynamo.2025-12-02T1740.a6877dba Release-Initiated-By: https://github.com/lindseydew Release-Workflow-Run: https://github.com/guardian/atom-maker/actions/runs/19868005437 Release-Notes: #133
|
@lindseydew has published a preview version of this PR with release workflow run #27, based on commit a6877db: 8.0.0-PREVIEW.ldupgrade-dynamo.2025-12-02T1740.a6877dba Want to make another preview release?Click 'Run workflow' in the GitHub UI, specifying the ld/upgrade-dynamo branch, or use the GitHub CLI command: gh workflow run release.yml --ref ld/upgrade-dynamo Want to make a full release after this PR is merged?Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command: gh workflow run release.yml |
|
|
||
| protected def scan: DataStoreResult[List[Json]] = { | ||
| Try { | ||
| table.scan().iterator().asScala.toList |
There was a problem hiding this comment.
It looks like there's a table.scan().items() method available, which would give you a list of documents, rather than a list of pages of documents.
I wondered if there was a performance difference between the two but I can't see anything obvious about this in the docs. So just suggesting it as slight simplification of the code, but I'm happy either way :)
| table.scan().iterator().asScala.toList | |
| table.scan().items().iterator().asScala.toList |
There was a problem hiding this comment.
Ah cool thanks, that's a good point. I think we will do some refactoring of this after the upgrade, so I'll have a look into doing that then 👍
bryophyta
left a comment
bryophyta
left a comment
There was a problem hiding this comment.
the code changes look good to me, and I've tested with a deploy of guardian/media-atom-maker#1428 to CODE, which seems to all work as expected 👍
just one small totally-optional comment below
2 participants
What does this change?
This adds a new dynamo access that uses the java sdk version
How to test
How can we measure success?
Have we considered potential risks?
Images
Accessibility