feat(GuCertificate): Remove DeletionPolicy and UpdateReplacePolicy
#2808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 640ce2d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Typically, the `DeletionPolicy` is set to support CloudFormation imports. The `AWS::CertificateManager::Certificate` resource does not yet support CFN imports. See https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/resource-import-supported-resources.html.
akash1810
force-pushed
the
aa/acm-certificate-policy
branch
from
fd83c60 to
640ce2d
Compare
Contributor
|
Although these properties don't really seem to be necessary, does removing them provide any particular benefit for users? If not, I'd be tempted to leave it as is to avoid adding friction for pattern users who are relying on automated library upgrades. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Typically, the
DeletionPolicyis set to support CloudFormation imports. TheAWS::CertificateManager::Certificateresource does not yet support CFN imports1, so stop settingDeletionPolicyandUpdateReplacePolicy.How to test
See CI and updated snapshots.
Checklist
Footnotes
See also https://github.com/guardian/cdk/pull/390#discussion_r608459080. ↩
Consider whether this is something that will mean changes to projects that have already been migrated, or to the CDK CLI tool. If changes are required, consider adding a checklist here and/or linking to related PRs. ↩
If you are adding a new construct or pattern, has new documentation been added? If you are amending defaults or changing behaviour, are the existing docs still valid? ↩