Skip to content

Update thrift library #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fredex42 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update thrift library #249

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2437e54
update the Thrift library
fredex42 Jul 3, 2024
9b369b3
update dependencies for Thrift, also update Circe json
fredex42 Jul 4, 2024
0144ace
damn there was a subdependency problem
fredex42 Jul 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@ import sbtrelease.ReleaseStateTransformations.*
import sbtversionpolicy.withsbtrelease.ReleaseVersion

// dependency versions
val contentEntityVersion = "3.0.3"
val contentAtomVersion = "4.0.4"
val contentEntityVersion = "4.0.0"
val contentAtomVersion = "6.0.0"
val storyPackageVersion = "2.2.0"
val thriftVersion = "0.15.0"
val thriftVersion = "0.20.0"
Copy link
Member

@rtyley rtyley Jan 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to note that the latest version of Thrift is apparently v0.21.0, released September 2024 - but no need to jump to that now, just noting that it exists.

val scroogeVersion = "22.1.0" // update plugins too if this version changes
val circeVersion = "0.14.1"
val circeVersion = "0.14.9"
val fezziwigVersion = "2.0.0"

// dependency versions (for tests only)
Expand Down Expand Up @@ -117,7 +117,7 @@ lazy val json = Project(id = "content-api-models-json", base = file("json"))
"io.circe" %% "circe-core" % circeVersion,
"io.circe" %% "circe-generic" % circeVersion,
"io.circe" %% "circe-parser" % circeVersion,
"io.circe" %% "circe-optics" % circeVersion,
"io.circe" %% "circe-optics" % "0.14.1", //circe-optics is now released at a difference cadence to circe main project - https://github.com/circe/circe-optics
"org.scalatest" %% "scalatest" % scalaTestVersion % Test,
"com.google.guava" % "guava" % guavaVersion % Test,
"org.gnieh" %% "diffson-circe" % diffsonVersion % Test
Expand Down