Add product element type and decoders#263
Merged
emma-imber merged 10 commits intomainfrom Oct 30, 2025
Merged
Conversation
Co-authored-by: Oliver Abrahams <ollie.abrahams@guardian.co.uk>
…ter/product-element # Conflicts: # models/src/main/thrift/content/v1.thrift
simonbyford
approved these changes
Oct 29, 2025
Contributor
simonbyford
left a comment
simonbyford
left a comment
There was a problem hiding this comment.
I can see this is identical to the PR for the temporary version of the model but with tempProductTypeData renamed to productTypeData. This seems to make sense so I'm happy to approve 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
co-authored by @charleycampbell
co-authored by @oliverabrahams
Adds the product element and supporting types to thrift, and adds corresponding encoders and decoders.
See corresponding flexible-model PR.
See RFC.
See draft PR with temp data for testing in CAPI CODE.