Skip to content

Set up repo for NPM trusted publishing #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jonathonherbert merged 5 commits into from
Feb 2, 2026
Merged

Set up repo for NPM trusted publishing #294

jonathonherbert merged 5 commits into from
Feb 2, 2026

Conversation

@jonathonherbert
Copy link
Contributor

@jonathonherbert jonathonherbert commented Jan 30, 2026 •
edited
Loading

What does this change?

Sets this repo up for trusted publishing —

  • removes the NPM_TOKEN
  • adds id-token to the workflow permissions for the job that contains the publish step
  • bumps NPM to > 11.5.1
  • updates scmInfo to add the repository to the package.json

How to test

Run the release process on the branch. The NPM step should succeed.

@jonathonherbert jonathonherbert requested a review from a team as a code owner January 30, 2026 12:49
gu-scala-library-release bot added a commit that referenced this pull request Jan 30, 2026
@gu-scala-library-release
v37.0.1-PREVIEW.jshtrusted-publishing.2026-01-30T1243.b1661c2c publis…
38b3102 
…hed by jonathonherbert

jonathonherbert published release version 37.0.1-PREVIEW.jshtrusted-publishing.2026-01-30T1243.b1661c2c
using gha-scala-library-release-workflow: https://github.com/guardian/gha-scala-library-release-workflow

Release-Version: 37.0.1-PREVIEW.jshtrusted-publishing.2026-01-30T1243.b1661c2c
Release-Initiated-By: https://github.com/jonathonherbert
Release-Workflow-Run: https://github.com/guardian/content-api-models/actions/runs/21516211137
Release-Notes: #294
@gu-scala-library-release
Copy link
Contributor

gu-scala-library-release bot commented Jan 30, 2026

@jonathonherbert has published a preview version of this PR with release workflow run #112, based on commit b1661c2:

37.0.1-PREVIEW.jshtrusted-publishing.2026-01-30T1243.b1661c2c

Want to make another preview release?

Click 'Run workflow' in the GitHub UI, specifying the jsh/trusted-publishing branch, or use the GitHub CLI command:

gh workflow run release.yml --ref jsh/trusted-publishing

Want to make a full release after this PR is merged?

Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command:

gh workflow run release.yml

@jonathonherbert jonathonherbert self-assigned this Jan 30, 2026
@jonathonherbert jonathonherbert added the maintenance Departmental tracking: maintenance work, not a fix or a feature label Jan 30, 2026
@jonathonherbert jonathonherbert added this to the Health milestone Jan 30, 2026
gu-scala-library-release bot added a commit that referenced this pull request Jan 30, 2026
@gu-scala-library-release
v37.0.1-PREVIEW.jshtrusted-publishing.2026-01-30T1443.4a4de1e0 publis…
4f41823 
…hed by jonathonherbert

jonathonherbert published release version 37.0.1-PREVIEW.jshtrusted-publishing.2026-01-30T1443.4a4de1e0
using gha-scala-library-release-workflow: https://github.com/guardian/gha-scala-library-release-workflow

Release-Version: 37.0.1-PREVIEW.jshtrusted-publishing.2026-01-30T1443.4a4de1e0
Release-Initiated-By: https://github.com/jonathonherbert
Release-Workflow-Run: https://github.com/guardian/content-api-models/actions/runs/21519664646
Release-Notes: #294
@gu-scala-library-release
Copy link
Contributor

gu-scala-library-release bot commented Jan 30, 2026

@jonathonherbert has published a preview version of this PR with release workflow run #113, based on commit 4a4de1e:

37.0.1-PREVIEW.jshtrusted-publishing.2026-01-30T1443.4a4de1e0

Want to make another preview release?

Click 'Run workflow' in the GitHub UI, specifying the jsh/trusted-publishing branch, or use the GitHub CLI command:

gh workflow run release.yml --ref jsh/trusted-publishing

Want to make a full release after this PR is merged?

Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command:

gh workflow run release.yml

gu-scala-library-release bot added a commit that referenced this pull request Feb 2, 2026
@gu-scala-library-release
v37.0.1-PREVIEW.jshtrusted-publishing.2026-02-02T0958.7899d16f publis…
a9f8b05 
…hed by jonathonherbert

jonathonherbert published release version 37.0.1-PREVIEW.jshtrusted-publishing.2026-02-02T0958.7899d16f
using gha-scala-library-release-workflow: https://github.com/guardian/gha-scala-library-release-workflow

Release-Version: 37.0.1-PREVIEW.jshtrusted-publishing.2026-02-02T0958.7899d16f
Release-Initiated-By: https://github.com/jonathonherbert
Release-Workflow-Run: https://github.com/guardian/content-api-models/actions/runs/21585489651
Release-Notes: #294
@gu-scala-library-release
Copy link
Contributor

gu-scala-library-release bot commented Feb 2, 2026

@jonathonherbert has published a preview version of this PR with release workflow run #114, based on commit 7899d16:

37.0.1-PREVIEW.jshtrusted-publishing.2026-02-02T0958.7899d16f

Want to make another preview release?

Click 'Run workflow' in the GitHub UI, specifying the jsh/trusted-publishing branch, or use the GitHub CLI command:

gh workflow run release.yml --ref jsh/trusted-publishing

Want to make a full release after this PR is merged?

Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command:

gh workflow run release.yml

gu-scala-library-release bot added a commit that referenced this pull request Feb 2, 2026
@gu-scala-library-release
v37.0.1-PREVIEW.jshtrusted-publishing.2026-02-02T1025.823b7a0c publis…
4f94d38 
…hed by jonathonherbert

jonathonherbert published release version 37.0.1-PREVIEW.jshtrusted-publishing.2026-02-02T1025.823b7a0c
using gha-scala-library-release-workflow: https://github.com/guardian/gha-scala-library-release-workflow

Release-Version: 37.0.1-PREVIEW.jshtrusted-publishing.2026-02-02T1025.823b7a0c
Release-Initiated-By: https://github.com/jonathonherbert
Release-Workflow-Run: https://github.com/guardian/content-api-models/actions/runs/21586360110
Release-Notes: #294
@gu-scala-library-release
Copy link
Contributor

gu-scala-library-release bot commented Feb 2, 2026

@jonathonherbert has published a preview version of this PR with release workflow run #115, based on commit 823b7a0:

37.0.1-PREVIEW.jshtrusted-publishing.2026-02-02T1025.823b7a0c

Want to make another preview release?

Click 'Run workflow' in the GitHub UI, specifying the jsh/trusted-publishing branch, or use the GitHub CLI command:

gh workflow run release.yml --ref jsh/trusted-publishing

Want to make a full release after this PR is merged?

Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command:

gh workflow run release.yml

RikRootsGuardian
RikRootsGuardian approved these changes Feb 2, 2026
View reviewed changes
Copy link

@RikRootsGuardian RikRootsGuardian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to approve

groakland
groakland approved these changes Feb 2, 2026
View reviewed changes
Copy link

@groakland groakland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathonherbert jonathonherbert merged commit db3135f into main Feb 2, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@groakland groakland groakland approved these changes

@RikRootsGuardian RikRootsGuardian RikRootsGuardian approved these changes

Assignees

@jonathonherbert jonathonherbert

Labels

maintenance Departmental tracking: maintenance work, not a fix or a feature

Projects

None yet

Milestone

Health

Development

Successfully merging this pull request may close these issues.

3 participants

@jonathonherbert @groakland @RikRootsGuardian