Add (configurable) suggestions for queryStr nodes#101
Open
jonathonherbert wants to merge 5 commits intojsh/pos-based-suggestionsfrom
Open
Add (configurable) suggestions for queryStr nodes#101jonathonherbert wants to merge 5 commits intojsh/pos-based-suggestionsfrom
jonathonherbert wants to merge 5 commits intojsh/pos-based-suggestionsfrom
Conversation
Contributor
Contributor
jonathonherbert
force-pushed
the
jsh/pos-based-suggestions
branch
from
184d17b to
8b2f271
Compare
jonathonherbert
force-pushed
the
jsh/suggestions-for-query-str
branch
from
054311b to
cd7c39c
Compare
jonathonherbert
force-pushed
the
jsh/pos-based-suggestions
branch
3 times, most recently
from
33bc62c to
1dc8435
Compare
…selection position either side of a character to perform correctly), and adjust debug visualisation
…tion, add tests for queryStr typeahead, and fix tests
jonathonherbert
force-pushed
the
jsh/suggestions-for-query-str
branch
from
cd7c39c to
386a2df
Compare
jonathonherbert
force-pushed
the
jsh/suggestions-for-query-str
branch
from
386a2df to
5c8dd11
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds the configuration option
showTypeaheadForQueryStrto theTypeaheadclass, defaulting tofalsefor backwards compatibility, which enables suggestions for queryStr positions that have a length greater thanminCharsForQueryStrTypeahead(default 2):How to test
Try typing partial keys directly into the editor — for example,
taorsect. You should see suggestions. Accepting them withEntershould create a chip with that key, and move you to value position.