Add option to insert content to a new node during creation#454
Draft
Add option to insert content to a new node during creation#454
Conversation
Contributor
|
This would be a great improvement. Spoken AOB, but to summarise, for a public API the surface area here allows a few footguns:
Ideally you'd pass the data (typesafely!), and the repeater would handle the translation from data to node. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Provides a new optional argument to
RepeaterFieldView.addChildAfter()andRepeaterFieldView.addChildAtEnd().The old behaviour is kept; that is, if you call
field.view.addChildAfter(index)a blank field will still be inserted. However, you can now callfield.view.addChildAfter(index, { nodeContent: someNode })and have that field inserted with the given node.As a convenience, you can also call
field.addChildAfter(index, {textContent: someTextString})and have a node automatically created for you.How to test
How can we measure success?
Have we considered potential risks?
Images
Accessibility