Add recommendation for logging in .json format to scala recommendations#88
Open
michaelwmcnamara wants to merge 3 commits intomainfrom
Open
Add recommendation for logging in .json format to scala recommendations#88michaelwmcnamara wants to merge 3 commits intomainfrom
michaelwmcnamara wants to merge 3 commits intomainfrom
Conversation
Member
|
I'm not sure we're at the recommendation stage yet? Should we add this to the proposal doc instead for now? cc @guardian/devx-operations. |
johnduffell
reviewed
Feb 12, 2025
Member
johnduffell
left a comment
johnduffell
left a comment
There was a problem hiding this comment.
probably not needed any more now that play 2.8 is out of service and we should all be on play 3.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
When logging in .json format for a scala app, it is necessary to use net.logstash.logback.encoder.LogstashEncoder.
When using this with Play 8.x you are exposed to a Denial of Service vulnerability in the Jackson library used by this version of Play.
This change documents this problem and adds details for the current workaround to resolve this issue.
Trello card: https://trello.com/c/tiXyFoIv/1259-support-ingesting-json-logs-and-define-best-practice-on-this