Fixes audio in samples to work with dagonruby v241 #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running the sample in the current dragonruby version 241, it crashes with the message the used `queue_sound` method on the GTK runtime is missing a parameter. Sometime in the last year, the `queue_sound` method changed expecting a gain (float 0-1) parameter. See https://github.com/DragonRuby/dragonruby-game-toolkit-contrib/blob/main/dragon/runtime.rb#L886 This did not impact the public interface using `arg.outputs.sounds << "path"` notation, which used in all documentation and examples. I therefore switched the code to this notation and now the example is working fine again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Running the sample in the current dragonruby version 241, it crashes with the message the used
queue_soundmethod on the GTK runtime is missing a parameter. Sometime in the last year, thequeue_soundmethod changed expecting a gain (float 0-1) parameter. See https://github.com/DragonRuby/dragonruby-game-toolkit-contrib/blob/main/dragon/runtime.rb#L886This did not impact the public interface using
arg.outputs.sounds << "path"notation, which used in all documentation and examples. I therefore switched the code to this notation and now the example is working fine again. :)bye,
Dahie