Extend component definition api #18
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The results are analogue to Ruby-on-Rails to support namespaced classes. It's also more predictable - the original implementation would change encoding and drop characters.
This change was motivated by two things: - Components needed to be declared using the class name, which made it necessary to manually reorder required imports. - Reusing Components was hard and I often ended with many classes doing the same things So what this does is to give the option to declare Components as underscored symbol names. Declaration with class names as before is still supported. When a component is declared, the name can be given as Class name, underscored symbol or with an own title - if a class_name is given in the options string. Internally in EntityStore and ComponentStore all index to the name symbol now.
This is a convencience thing for simple Components.
If you only have one value in the component, like a list, it makes the calling methods of the list nicer.
```
class A < Draco::Component
attribute :list, default: []
delegate :each, :count, :<<, :[], to: :list
end
a = A.new
a << "add me to the list"
a.count = 1
Dahie
force-pushed
the
extend-component-definition-api
branch
from
432b2c6 to
b4b9d9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still work in progress and will get cleanup later. I may also take out the delegation into a plugin