Skip to content

add missing type exports, prevent moving dist files to root#150

Closed
az0uz wants to merge 4 commits intogzuidhof:masterfrom
az0uz:az0uz/fix_exports
Closed

add missing type exports, prevent moving dist files to root#150
az0uz wants to merge 4 commits intogzuidhof:masterfrom
az0uz:az0uz/fix_exports

Conversation

@az0uz
Copy link
Contributor

@az0uz az0uz commented Dec 30, 2023

  • some types are not exported, it is very useful to let users access public API types so they don't have to re-define type of objects passed to the zarr.js api.
  • keeps build files in dist/ instead of moving them to the root dir, moving them breaks development workflow when using npm link && npm run start and npm run link zarr in another project to use the current dev version of zarr.
  • remove hooks to copy and git clean before / after build

@az0uz
Copy link
Contributor Author

az0uz commented Dec 30, 2023

Sorry I already created a PR for this 😅 Duplicate of #149

@az0uz az0uz closed this Dec 30, 2023
@az0uz az0uz deleted the az0uz/fix_exports branch December 30, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments