Propagated HTTP errors in HTTPStore containsItem function#151
Open
zonia3000 wants to merge 1 commit intogzuidhof:masterfrom
Open
Propagated HTTP errors in HTTPStore containsItem function#151zonia3000 wants to merge 1 commit intogzuidhof:masterfrom
zonia3000 wants to merge 1 commit intogzuidhof:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I'm working on a prototype using zarr.js and an authenticated backend. It would be very useful to be able to distinguish between 200, 404 and "something else" HTTP statuses inside the
containsItem()function of theHTTPStore, so that one can catch theHTTPErrorand display a proper error message to the user.I see that the
getItem()function already considers these 3 cases, so I think that the same logic could be applied tocontainsItem().Note: I'm working on Fractal project with @jluethi and @tcompa