Update readme File + change code for printf function#45
Open
Stackmemory0x00 wants to merge 3 commits intoh0mbre:masterfrom
Open
Update readme File + change code for printf function#45Stackmemory0x00 wants to merge 3 commits intoh0mbre:masterfrom
Stackmemory0x00 wants to merge 3 commits intoh0mbre:masterfrom
Conversation
Hello, world! is a character array rather a char.
It's better(I think) to call printf function one time, pass all arguments in one go rather than calling it 3 times. The output will be the same but as a beginner(like me) , its very important always to think of efficent and fast code exeuction from the get go.
update No of arguments condition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, world! is a character array rather a char. This distiguish is very important specially for beginners and those coming from other languages like JS where single and double quote is same thing.
I have also updated the code for printf because as a beginner , I think its very important to think of good and efficient code from the get go. Instead of calling the funciton 3 times , its better to call it one time , pass all arugments in one go.
I also added return statement. I have spent many hours as a beginner debugging functions I wrote to find out that I did not include a return statement for the value I have calculated in my function :)