Андрей Смирдин, Лиза Василенко. Биржа Фрилансеров #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # tcp/message/src/message.cpp
h31
reviewed
Mar 27, 2019
|
|
||
| while (true) { | ||
| client.GetLine(line); | ||
| if (sscanf(line.c_str(), "a customer %s", arg)) { |
Owner
There was a problem hiding this comment.
Желательно указывать размер буфера arg, чтобы не произошло переполнение.
| } | ||
|
|
||
| bool Message::GetBody(std::string *body, size_t length, int sockfd) { | ||
| auto buf = new char[length]; |
Owner
There was a problem hiding this comment.
Зачем выделять buf, если можно было сразу передать body->data() в Get? Естественно, после resize.
| return status; | ||
| } | ||
|
|
||
| MarketServer::ClientStatus MarketServer::WorkWithFreelancer(Freelancer *freelancer, const Message &message) { |
Owner
There was a problem hiding this comment.
Достаточно большие функции, которые можно было бы разбить на несколько.
Owner
|
А так всё достаточно хорошо и красиво, молодцы. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Задание 1 из дополнительной методички.
Лиза -- сервер, Андрей -- клиент