FeatureFlag for MacOs Support #10080
Conversation
👷 Deploy Preview for chef-habitat processing.
|
There was a problem hiding this comment.
Pull request overview
This PR introduces a feature flag (HAB_FEAT_MACOS_NATIVE_SUPPORT) to enable native studio support on macOS, allowing macOS users to run Habitat Studio natively when the feature flag is set, rather than defaulting to Docker. The implementation modifies the studio entry logic to check for this feature flag on Unix systems (specifically targeting macOS) and routes to the appropriate studio implementation.
Key changes:
- Adds
MACOS_NATIVE_SUPPORTfeature flag with environment variableHAB_FEAT_MACOS_NATIVE_SUPPORT - Updates studio entry logic to support native studio on macOS when feature flag is enabled
- Replaces hardcoded package identifier with environment variable
HAB_STUDIO_BACKLINE_PKGin Darwin studio script - Removes two unused feature flags (
SERVICE_CONFIG_FILESandSTRUCTOPT_CLI)
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| components/common/src/lib.rs | Adds MACOS_NATIVE_SUPPORT feature flag and removes two unused flags (SERVICE_CONFIG_FILES, STRUCTOPT_CLI) |
| components/hab/src/command/studio/enter.rs | Updates studio entry logic to support macOS native studio behind feature flag, changes cfg from target_os to target_family for Unix support |
| components/studio/libexec/hab-studio-type-darwin-default.sh | Replaces hardcoded chef/hab-backline with environment variable ${HAB_STUDIO_BACKLINE_PKG} for flexibility |
| components/hab/install.sh | Removes trailing whitespace (formatting cleanup only) |
agadgil-progress
force-pushed
the
agadgil/hab-2-darwin
branch
from
e6eae87 to
c791352
Compare
agadgil-progress
force-pushed
the
agadgil/hab-2-darwin
branch
from
c791352 to
b254102
Compare
|
To test this PR, a bit of preparatory work is required - that is to download the (the HAB_AUTH_TOKEN needs to be set). Once these packages are installed one can test the studio by - |
- `SERVICE_CONFIG_FILES` - `STRUCTOPT_CLI` Signed-off-by: Abhijit Gadgil <agadgil@progress.com>
Added a Feature Flag `MACOS_NATIVE_SUPPORT`. All the MacOS Features will be gated by this runtime flag till we are ready to support MacOS fully. Signed-off-by: Abhijit Gadgil <agadgil@progress.com>
Signed-off-by: Abhijit Gadgil <agadgil@progress.com>
agadgil-progress
force-pushed
the
agadgil/hab-2-darwin
branch
from
b254102 to
9db2f3a
Compare
|
No description provided.