[JBEAP-29211] Add filter to Configurable HTTP Server Mechanism Factory #127
Conversation
kstekovi
changed the title
kstekovi
changed the title
| flip(formId: string, attributeName: string, value: boolean): Chainable<void>; | ||
| /** | ||
| * Set text value to form input. | ||
| * Set text value to form input. The id of form filed is concatenated like: cy.get("#" + configurationFormId + "-" + attributeName + "-editing"); |
There was a problem hiding this comment.
I didn't get how is the element ID concatenate. I have to look at the implementation to understand what I have use for formId and attributeName. So i just the important part into description.
There was a problem hiding this comment.
I see, perhaps
@param formId - The ID of section which contain form inputs. This parameter is appended with -editing to obtain full ID is more clear. On the other hand most of function present in this class do the same, without this explanation, introducing Inconsistency.
However I don't have strong opinion about this
...lytron/test-configuration-subsystem-elytron-configurable-http-server-mechanism-factory.cy.ts
Outdated
Show resolved
Hide resolved
...lytron/test-configuration-subsystem-elytron-configurable-http-server-mechanism-factory.cy.ts
Outdated
Show resolved
Hide resolved
...lytron/test-configuration-subsystem-elytron-configurable-http-server-mechanism-factory.cy.ts
Show resolved
Hide resolved
| }; | ||
|
|
||
| const addButtonInForm = "hal-modal > div > div > div.modal-footer"; | ||
| const filtrsButtonForConfigurableHttpServer = "#hal-uid-1"; |
There was a problem hiding this comment.
this random number changes between version, ID shouldn't be used
There was a problem hiding this comment.
This is the ID. Or do you mean something else?
There was a problem hiding this comment.
yes, the ID suffix is random number and shouldnt be relied on
| cy.addInTable(httpServerMechanismFactory + "-table"); | ||
| cy.text(factoryForm.id, factoryForm.fieldName.name, factoryForm.fieldName.value); | ||
| cy.text(factoryForm.id, factoryForm.fieldFactory.name, factoryForm.fieldFactory.value); | ||
| cy.addSingletonResource(addButtonInForm); |
There was a problem hiding this comment.
| cy.addSingletonResource(addButtonInForm); | |
| cy.confirmAddResourceWizard(); |
| const filterForm = { | ||
| id: httpServerMechanismFactoryFiltrs + "-add", | ||
| fieldEnabled: { | ||
| id: "#" + httpServerMechanismFactoryFiltrs + "-add-editing > div:nth-child(2)", |
There was a problem hiding this comment.
Try avoiding nth-child method for clarity
There was a problem hiding this comment.
I would like but here it nonstandard check to verify the text. The element itself doesn't have any specific ID to be able use as a selector.
There was a problem hiding this comment.
Can't we use something like here:
| cy.navigateToSpecificChannel(managementEndpoint, channels.url.name); | ||
| cy.editForm(channelForm); | ||
| cy.get(".tm-tag-remove").click() | ||
| cy.get(".tm-tag-remove").click(); |
There was a problem hiding this comment.
I don't disagree with this changes, but it's unnecessarily increasing changed files/PR size here
2 participants
Thanks for submitting your Pull Request!
Please delete this text, and add a link to the public Jira issue and/or Berg issue solved by this PR, if available.
If this PR is not for the 'main' branch you must add a link to the equivalent change in 'main'.
Remember to use the Jira issue ID or Berg issue number in the PR title and any commits, if available.
Keep the title/summary of PR and any commits descriptive, so that the repository history is human readable.