Open
Conversation
**Note** This is not a gist, so I had to make a pull request to give you feedback. Take a look at my suggested changes in the other tab. # Candy Machine | Requirement | Comments |---|--- | Well formatted code | Good space breaks between sections, but you didn't indent at all, see my changes above | Prompts for the amount of money | 👍 | Displays candy options and reads in user select | 👍 | Determines if the user can afford it | Mostly yes | Calculates the user's change |⚠️ It gives me negative change if I have $0.50 and order a twix | `Optional` Handle when the buyer enters "C" or "c" so that it works as expected | NA | `Optional` Do something appropriate when the buyer enters an invalid amount for the money and an invalid selection | NA ## Summary Not bad, things to work on include testing the app more throughly with different amounts of money and improving your code formatting to make it more readable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note This is not a gist, so I had to make a pull request to give you feedback. Take a look at my suggested changes in the other tab.
Candy Machine
OptionalHandle when the buyer enters "C" or "c" so that it works as expectedOptionalDo something appropriate when the buyer enters an invalid amount for the money and an invalid selectionSummary
Not bad, things to work on include testing the app more throughly with different amounts of money and improving your code formatting to make it more readable.