Various fixes, 10x installation size reduction#29
Various fixes, 10x installation size reduction#29halfmexican merged 4 commits intohalfmexican:mainfrom
Conversation
Additionally, remove the Vala runtime extension. It is already included in the Gnome runtime.
Dramatically reduces size of the final installation (84MB -> 8MB).
Use namespaces explicitly instead.
|
Thank you so much for the changes! I've been on a work trip. You're doing some much needed clean up and getting around to some things I should've done sooner 😅 JSON is less than ideal and wanted to use something else for this project, but was advised to start with JSON for simplicity. Thanks again for your excellent contributions and the detailed explanation. This is a significant improvement! |
|
It's been a bit, but from what I remember, the JSON file also probably could be cut down by a fair bit: I don't think all of the data contained in it is actually used, you can freely convert between emojis and their code points, and all of the URLs share the same beginning. |
|
Hello. I'm curious: Why were you eliminating the |
Mostly to be more explicit and avoid ambiguity - for example, there are |
I felt a degree of responsibility to fix at least some of this upon stumbling across it...
usingstatement and use namespaces directly - thankfully, this one was already mostly doneMy next suggestion would be to avoid storing the JSON data (
data_objectandsupported_emojis) in its original form long-term and instead pack it on loading into a more specific data structure to reduce memory consumption. I'm not down for this level of rewrite myself right now. Also, YAML is IMO much nicer for Flatpak manifests, but that's personal, and thus I haven't touched that.