Minor patches #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes warnings like
Use of uninitialized value $result{"sp"} in string eq at ./opendmarc-halonlog line 40
The spf result can be "invalid" which results in an empty spf value. OpenDMARC chokes on that with: opendmarc-import: failed to insert message: Incorrect integer value: '' for column 'spf' at row 1 By converting the possible values into a hash and use -1 if the spf result is not in the hash we make OpenDMARC happy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the changes we made to our local installation, perhaps it can help others too. Feel free to cherry-pick.