Skip to content
/ app-polo Public

Add support for SKCC logging#74

Open
alduhoo wants to merge 1 commit intoham2k:mainfrom
alduhoo:aldoms/skcc/extension
Open

Add support for SKCC logging#74
alduhoo wants to merge 1 commit intoham2k:mainfrom
alduhoo:aldoms/skcc/extension

Conversation

@alduhoo
Copy link
Contributor

@alduhoo alduhoo commented Oct 8, 2024

Add support for SKCC. Adds an extension that downloads member data and autocompletes the name/QTH/number after entering the callsign.

Also added typescript support.

Copy link
Contributor

@sd sd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not against TypeScript, but right now the rest of the codebase is all in plain JS, and this PR randomly changes lots of files to be TS, even outside of the skcc extension.

I think the easiest thing right now is to just use plain JS.

Also, the method to load data files changed from RNFetchBlob.fetch() to our own fetchAndProcessURL which hides some of the details, and implements ETag caching. Look at the data file logic for other extensions for reference.

@alduhoo
Copy link
Contributor Author

alduhoo commented Oct 8, 2024

I'm not against TypeScript, but right now the rest of the codebase is all in plain JS, and this PR randomly changes lots of files to be TS, even outside of the skcc extension.

I think the easiest thing right now is to just use plain JS.

Also, the method to load data files changed from RNFetchBlob.fetch() to our own fetchAndProcessURL which hides some of the details, and implements ETag caching. Look at the data file logic for other extensions for reference.

I think adopting TypeScript would be a good move as it will allow developers to propose changes faster and makes it easier to navigate the codebase. One of the advantages of TypeScript is that you can gradually migrate the code, so you don't have to migrate it all at once. But that could probably be done as a separate PR.

I'll remove the typescript changes and update the file loading to the latest,

@alduhoo alduhoo force-pushed the aldoms/skcc/extension branch from 0fed970 to 2cf6a47 Compare October 8, 2024 05:24
@alduhoo alduhoo marked this pull request as ready for review October 8, 2024 05:25
@alduhoo alduhoo requested a review from sd October 8, 2024 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants