Add missing php extensions to the composer.json #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aik099
requested changes
Jun 25, 2025
Comment on lines
17
to
21
| "require": { | ||
| "php": "^7.4|^8.0" | ||
| "php": "^7.4|^8.0", | ||
| "ext-ctype": "*", | ||
| "ext-dom": "*" | ||
| }, |
Member
There was a problem hiding this comment.
Please use consistent indentation.
Contributor
Author
There was a problem hiding this comment.
huh? what do you mean?
Contributor
Author
There was a problem hiding this comment.
oh my god.. why does it use tabs.
And the extra is not in tabs ^^
There was a problem hiding this comment.
Pull Request Overview
This PR adds missing PHP extension requirements to composer.json in response to issue #88.
- Adds "ext-ctype" and "ext-dom" to the "require" section to ensure required extensions are declared
- Ensures compatibility with phpunit by including ext-dom
pscheit
force-pushed
the
composer-add-extensions
branch
from
a691556 to
0084286
Compare
aik099
approved these changes
Jun 26, 2025
Member
|
Merging, thanks @pscheit . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #88
Think this is the right move: users can still ignore the requirements via Composer and tiptoe around the methods using this extensions.
Since phpunit requires ext-dom this is present anyway on most systems.