Fix Compiler error: overloaded functions have similar conversions#61
Merged
hankhsu1996 merged 4 commits intohankhsu1996:mainfrom Dec 3, 2025
Conversation
…ersions' when comparing basic_json to std::string_view
Owner
|
Hi, just got back from vacation. Thank you for your contribution. Can you fix the formatting issue that is failing the CI? |
Contributor
Author
|
Hi. Yes, I'll look into it. It seems MSVC is less strict about implicit conversions, that's why the fix compiles on my machine. |
Contributor
Author
|
I don't know what causes clang-format to fail here. |
Owner
|
You would need clang-format-19 to format it. You can set it up in your IDE to let it handle auto formatting, or run |
Contributor
Author
|
Thank you for the hint. Visual Studio has automatic clang-format built-in, but it seems that the change was too small to trigger it. Making more changes or running clang-format from the command line inserts the line break. |
Owner
|
LGTM, I'll merge it |
jbraun2025
deleted the
bugfix/compiler-error-overloaded-functions-have-similar-conversions
branch
This was referenced Dec 3, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #60 Compiler error: overloaded functions have similar conversions
Added coversion of JSON object member to std::string_view before comparison with other std::string_view