Support for the BMM150 by badfishblues · Pull Request #11 · hanyazou/BMI160-Arduino

badfishblues · 2019-06-27T17:29:09Z

Description

Library to support the Bosch BMI160 IMU with the BMM150 magnetometer connected as an auxillary sensor
Community effort with some untested functions, some of which have been commented out as a safety

New Features

getMotion9() to read all nine axis of data and the rhall values simultaneously
- has been cross referenced and tested against Bosch API
misc BMM150 support

…all(), added #defs for Rhall registers, added comments specifing not to use these functions without testing

Made Changes to support the BMM150

Delete bosch check code

hanyazou · 2019-06-30T06:44:48Z

Thank you for your contribution.
Because I don't have any time to test your code for now, I'm not sure if your code run on BMI160 w/o BMI150.
Did you try your changes with BMI160 without BMM150?
If your changes does not affect existing code and behavior, I can marge your changes into the repository.

* added suspendIMU and get_bit * Updated to 0.2.0

* wip with compile errors * wip: compiling * WIP: compiling, but mag not streaming * Almost working * FIFO seems to work at 25hz, but can't change freq * Minor cleanup. * Changed library Version in library.properties

hanyazou · 2019-11-09T22:33:03Z

BMI160.cpp

 void BMI160Class::resetStepCount() {
    reg_write(BMI160_RA_CMD, BMI160_CMD_STEP_CNT_CLR);
 }
-


Could you please eliminate these unintentional changes?

hanyazou · 2019-11-09T22:33:14Z

BMI160.cpp

 */
 uint8_t BMI160Class::getMotionDetectionThreshold() {
-    return reg_read(BMI160_RA_INT_MOTION_1);
+	return reg_read(BMI160_RA_INT_MOTION_1);


Could you please eliminate these unintentional changes?

hanyazou · 2019-11-09T22:33:20Z

BMI160.cpp

 */
 void BMI160Class::setMotionDetectionThreshold(uint8_t threshold) {
-    return reg_write(BMI160_RA_INT_MOTION_1, threshold);
+	return reg_write(BMI160_RA_INT_MOTION_1, threshold);


Could you please eliminate these unintentional changes?

hanyazou · 2019-11-09T22:33:29Z

BMI160.cpp

-                             BMI160_ANYMOTION_DUR_LEN);
+	return 1 + reg_read_bits(BMI160_RA_INT_MOTION_0,
+		BMI160_ANYMOTION_DUR_BIT,
+		BMI160_ANYMOTION_DUR_LEN);


Could you please eliminate these unintentional changes?

hanyazou · 2019-11-09T22:33:36Z

BMI160.cpp

-                   BMI160_ANYMOTION_DUR_LEN);
+	reg_write_bits(BMI160_RA_INT_MOTION_0, samples - 1,
+		BMI160_ANYMOTION_DUR_BIT,
+		BMI160_ANYMOTION_DUR_LEN);


Could you please eliminate these unintentional changes?

hanyazou · 2019-11-09T22:33:41Z

BMI160.cpp

+
 /** Get zero motion detection event acceleration threshold.
 * This register configures the detection threshold for Zero Motion interrupt
 * generation in the INT_MOTION[1] register. The unit of threshold is


Could you please eliminate these unintentional changes?

hanyazou · 2019-11-09T22:34:18Z

BMI160.h

-        uint8_t getMotionDetectionDuration();
-        void setMotionDetectionDuration(uint8_t duration);
+		uint8_t getMotionDetectionDuration();
+		void setMotionDetectionDuration(uint8_t duration);


Could you please eliminate these unintentional changes?

hanyazou · 2019-11-09T22:36:25Z

BMI160.h

+        void setMagFIFOEnabled(bool enabled);       //Added for BMM150 Support
+
+		bool getIntFIFOBufferFullEnabled();
        void setIntFIFOBufferFullEnabled(bool enabled);


Indent looks strange here.

hanyazou · 2019-11-09T22:36:33Z

BMI160.h

        bool getIntDataReadyEnabled();
        void setIntDataReadyEnabled(bool enabled);
-
+		


Could you please eliminate these unintentional changes?

hanyazou · 2019-11-09T22:37:43Z

BMI160.h

-        void getAcceleration(int16_t* x, int16_t* y, int16_t* z);
+        void getMotion9(int16_t* ax, int16_t* ay, int16_t* az, int16_t* gx, int16_t* gy, int16_t* gz, int16_t* mx, int16_t* my, int16_t* mz, uint16_t* rh);		//Added for BMM150 Support
+		void extractMotion9(uint8_t* buffer, int16_t* ax, int16_t* ay, int16_t* az, int16_t* gx, int16_t* gy, int16_t* gz, int16_t* mx, int16_t* my, int16_t* mz, uint16_t* rh);		//Added for BMM150 Support
+		void getAcceleration(int16_t* x, int16_t* y, int16_t* z);


Could you please eliminate these unintentional changes?
Please fix indentation here.

hanyazou · 2019-11-09T22:38:05Z

BMI160.h


        uint8_t getRegister(uint8_t reg);
        void setRegister(uint8_t reg, uint8_t data);
+		void setRegister(uint8_t reg, uint8_t data, uint8_t bitMask);


Please correct the indentation.

* Added changes to incorporate TwoWire instance passed by reference. * Added passing i2c instance.

badfishblues and others added 7 commits June 18, 2019 15:02

Made Changes to support the BMM150

9bf7f5d

Added library.properties to support the Arduino Library Manager

5bcb257

Updated the getMagneto() functions to match getMotion9(), added getRH…

15ec3fd

…all(), added #defs for Rhall registers, added comments specifing not to use these functions without testing

Commented out all untested functions

8e20a37

Merge pull request #1 from EmotiBit/v1.0

c12a022

Made Changes to support the BMM150

deleted bosch code linked to past commit

a0ea9c8

Merge pull request #2 from EmotiBit/deleteBosch

17f5aaf

Delete bosch check code

badfishblues and others added 2 commits October 31, 2019 15:35

suspendIMU() (#3)

eec0677

* added suspendIMU and get_bit * Updated to 0.2.0

Bmm fifo config (#4)

edab47e

* wip with compile errors * wip: compiling * WIP: compiling, but mag not streaming * Almost working * FIFO seems to work at 25hz, but can't change freq * Minor cleanup. * Changed library Version in library.properties

hanyazou reviewed Nov 9, 2019

View reviewed changes

nitin710 and others added 6 commits December 26, 2019 19:01

Adding support for Running on auxiliary I2C (#5)

a57c9ce

* Added changes to incorporate TwoWire instance passed by reference. * Added passing i2c instance.

Version bump in Lib Properties

43adb98

Changed library properties. URL changed after renaming repo.

468e06e

deleted log files

40ee6c0

conformed to ESP (#6)

77dc1f2

version bump to 0.3.3

5e12b44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support for the BMM150#11

Support for the BMM150#11
badfishblues wants to merge 15 commits intohanyazou:masterfrom
EmotiBit:master

badfishblues commented Jun 27, 2019

Uh oh!

hanyazou commented Jun 30, 2019

Uh oh!

hanyazou Nov 9, 2019

Uh oh!

hanyazou Nov 9, 2019

Uh oh!

hanyazou Nov 9, 2019

Uh oh!

hanyazou Nov 9, 2019

Uh oh!

hanyazou Nov 9, 2019

Uh oh!

hanyazou Nov 9, 2019

Uh oh!

hanyazou Nov 9, 2019

Uh oh!

hanyazou Nov 9, 2019

Uh oh!

hanyazou Nov 9, 2019

Uh oh!

hanyazou Nov 9, 2019

Uh oh!

hanyazou Nov 9, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		bool getIntDataReadyEnabled();
		void setIntDataReadyEnabled(bool enabled);

Conversation

badfishblues commented Jun 27, 2019

Description

New Features

Uh oh!

hanyazou commented Jun 30, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants