Wait for connack before doing anything else. #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many issues have been raised regarding video timeouts when using keyboard_and_video.py
I believe the issue comes from not calling
wait_for_connectionbetweenconnectandstart_videoI never have issues with video_effect.py and
wait_for_connectionis the only explanation I could find. I haven't been having issues withkeyboard_and_videoever since.I find forcing the users to call
wait_for_connectionthemselves to be very bug-prone (as we can see from this example), so I have opted to move it directly inconnect. This should take care of these issues forever.