Efremov Homework 6 #82
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 3, 2022 15:28
spajic
approved these changes
Jul 7, 2022
Collaborator
spajic
left a comment
spajic
left a comment
There was a problem hiding this comment.
Всё верно, но не хватает в case-study ответа на вопрос почему ничего не сломается, если мы уберём эту библиотеку из vendor.js
| - name: run sitespeedio test | ||
| uses: docker://sitespeedio/sitespeed.io:9.8.1-action | ||
| with: | ||
| args: https://d596-18-135-4-161.eu.ngrok.io -n 1 --budget.configPath ./homeBudget.json |
| - name: checkout code | ||
| uses: actions/checkout@v3 | ||
| - name: run sitespeedio test | ||
| uses: docker://sitespeedio/sitespeed.io:9.8.1-action |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Завел бюджет и
webpack-bundle-analyzerВ бюджет не укалдываемся, js весит больше чем 1 mb.
webpack-bundle-analyzerпоказал что в vendor много весит chart.js, у которого зависимость с moment.jsМы не первые кому не нравится эта зависимость, почитал треды, говорят в версях ^3.0.0 зависимости от moment.js нет, попытался обновить chart.js - не получилось, посыпались ошибки.
Убрал подгрузку chart.js и moment.js в vendor.
Отчет
webpack-bundle-analyzerстал выглядеть такИ мы уложились в бюджет
Настроил Github Actions