[potashin] optimization 6 #96
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potashin
commented
Jun 15, 2024
| - name: code checkout | ||
| uses: actions/checkout@v2 | ||
| - name: running sitespeed.io container with arguments and optional Docker options | ||
| run: docker run -v "$(pwd):/sitespeed.io" sitespeedio/sitespeed.io:34.2.0 https://www.sitespeed.io --budget.configPath homeBudget.json -n 1 No newline at end of file |
Author
There was a problem hiding this comment.
проверил через мр в своем форке:
https://github.com/potashin/rails-optimization-task6/actions/runs/9527161624/job/26263445497?pr=1
spajic
approved these changes
Jun 21, 2024
Collaborator
spajic
left a comment
spajic
left a comment
There was a problem hiding this comment.
Найс
На самом деле бюджет увеличивать не обязательно тут. Если попробовать как я писал в описании ДЗ полностью закомментировать всё в proCharts.js, то бюджет соблюдается.
У chart.js есть ещё зависимости, которые остались в vendor.js, например chartjs-color
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.