chore(validator): refine error msg for length validator without upper limit #44
+24
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattwang44
force-pushed
the
update-length-validator-error-msg
branch
3 times, most recently
from
427415a to
f223310
Compare
mattwang44
force-pushed
the
update-length-validator-error-msg
branch
from
f223310 to
1febe91
Compare
mattwang44
changed the title
mattwang44
changed the title
CJHwong
approved these changes
Jan 7, 2025
pkyosx
reviewed
Jan 7, 2025
mattwang44
force-pushed
the
update-length-validator-error-msg
branch
from
50f1f2f to
ca3eaf7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason
if the upper limit of the length validator is not given, the error message when violation would be
reason: Length of 'abc' must be between 5 and None, which is bizarre.Changes
make the error message in the format of
reason: Length of 'abc' must be greater than or equal to 5if the upper limit is not given.Test Scope
Checks