fix(deco): load body as json whenever content type has 'application/json' #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattwang44
force-pushed
the
fix-should-load-body-as-json-whenever-header-contains-application-json
branch
from
4f0ce45 to
40e0205
Compare
CJHwong
reviewed
Sep 22, 2025
- Add null check for request.content_type in decorator to prevent errors - Fix test utility to set content type in initial request creation instead of META - Ensures proper content_type property behavior for both WSGI and ASGI requests 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
CJHwong
approved these changes
Sep 22, 2025
mattwang44
force-pushed
the
fix-should-load-body-as-json-whenever-header-contains-application-json
branch
from
cf66eea to
f279e10
Compare
mattwang44
deleted the
fix-should-load-body-as-json-whenever-header-contains-application-json
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason
CS-5166
The POST requests with content type header not exactly to be but contains
application/json(e.g.Content-Type: application/json; charset=UTF-8) is always failed to pass the validation, as it's not serialized as a dictionary.Changes
load body as json whenever content type header has
application/jsonTest Scope
Checks