Bidi Pass evaluate on new document tests #3085
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request implements the "evaluate on new document" functionality for the WebDriver BiDi protocol, enabling preload scripts that execute before page load. The implementation adds dictionary serialization support and the three core methods needed for this feature.
- Implements
EvaluateFunctionOnNewDocumentAsync,EvaluateExpressionOnNewDocumentAsync, andRemoveScriptToEvaluateOnNewDocumentAsyncfor BiDi - Adds dictionary argument serialization to support complex object parameters
- Removes test expectations for evaluation.spec tests that now pass with BiDi
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/PuppeteerSharp/Bidi/BidiRealm.cs | Adds IDictionary handling in FormatArgumentAsync and implements SerializeDictionaryAsync for recursive dictionary serialization |
| lib/PuppeteerSharp/Bidi/BidiPage.cs | Implements evaluate on new document methods using BiDi's preload script functionality with appropriate function wrapping |
| lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.local.json | Removes test expectation failures for evaluation.spec tests that now pass with the new BiDi implementation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.