Open
Conversation
add documentation to run app for IOS version
add documentation to run app for IOS version
haruelrovix
reviewed
Oct 30, 2018
| A React Native Web app that fetches GitHub API. | ||
|
|
||
| - Run on Android and Web 🎉 | ||
| - Run on Android, IOS and Web 🎉 |
haruelrovix
requested changes
Oct 30, 2018
Owner
haruelrovix
left a comment
There was a problem hiding this comment.
@andangrd Thanks for your contribution! 👏 Could you please revert unnecessary changes related to Android and resolve the merge conflicts? Thanks.
| } | ||
|
|
||
| dependencies { | ||
| compile project(':react-native-vector-icons') |
Owner
There was a problem hiding this comment.
@andangrd could you please revert this file? These changes are unnecessary. It's already there, using implementation instead of compile.
implementation project(':appcenter')
implementation project(':appcenter-analytics')
implementation project(':appcenter-crashes')
implementation project(':react-native-vector-icons')| protected List<ReactPackage> getPackages() { | ||
| return Arrays.<ReactPackage>asList( | ||
| new MainReactPackage(), | ||
| new VectorIconsPackage(), |
| @@ -1,4 +1,7 @@ | |||
| rootProject.name = 'creaternwapp' | |||
| include ':react-native-vector-icons' | |||
Owner
There was a problem hiding this comment.
@haruelrovix unnecessary changes. Please revert this.
andangrd
commented
Oct 30, 2018
|
|
||
| ``` $ yarn add appcenter appcenter-analytics appcenter-crashes --exact ``` | ||
| 3. Link the plugins to the React Native app by using the react-native link command. | ||
| ``` |
Author
Owner
There was a problem hiding this comment.
@andangrd yeah, seems react-native link doesn't care whether the package already exists or not.
haruelrovix
reviewed
Oct 30, 2018
| 2. [AppCenter](https://docs.microsoft.com/en-us/appcenter/) | ||
| 3. [AppCenter for React Native](https://docs.microsoft.com/en-us/appcenter/sdk/getting-started/react-native) | ||
|
|
||
|
|
Owner
There was a problem hiding this comment.
@andangrd feel free to add this section if you want.
Suggested change
| ## Contributors | |
| - [haruelrovix](https://github.com/haruelrovix) | |
| - [andangrd](https://github.com/andangrd) | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Add IOS Version