Update vm-force-reset-policy for version 1.7
#955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
akashraj4261,
dariavladykina and
jillian-maroket
|
jillian-maroket
requested review from
Vicente-Cheng
and removed request for
akashraj4261 and
dariavladykina
Vicente-Cheng
previously approved these changes
Jan 15, 2026
Contributor
Vicente-Cheng
left a comment
Vicente-Cheng
left a comment
There was a problem hiding this comment.
thanks for the update!
docs/advanced/settings.md
Outdated
| When the node becomes unavailable or is powered off, the VM only restarts and does not migrate. | ||
|
|
||
| **Default value**: `{"enable":true, "period":300}` | ||
| * `period`: Indicates how long to wait before adding the `kubevirt.io/drain` taint to the failed nodes. It will trigger the migration. |
Contributor
There was a problem hiding this comment.
Suggested change
| * `period`: Indicates how long to wait before adding the `kubevirt.io/drain` taint to the failed nodes. It will trigger the migration. | |
| - `period`: Number of seconds Harvester waits before adding the `kubevirt.io/drain` taint to the failed nodes. This option triggers the migration of the virtual machine. |
docs/advanced/settings.md
Outdated
|
|
||
| **Default value**: `{"enable":true, "period":300}` | ||
| * `period`: Indicates how long to wait before adding the `kubevirt.io/drain` taint to the failed nodes. It will trigger the migration. | ||
| * `vmMigrationTimeout`: Indicates how long to wait before adding the `node.kubernetes.io/out-of-service` taint to the failed nodes. It will force cleanup the orphan resources. |
Contributor
There was a problem hiding this comment.
Suggested change
| * `vmMigrationTimeout`: Indicates how long to wait before adding the `node.kubernetes.io/out-of-service` taint to the failed nodes. It will force cleanup the orphan resources. | |
| - `vmMigrationTimeout`: Number of seconds Harvester waits before adding the `node.kubernetes.io/out-of-service` taint to the failed nodes. This option forces cleanup of the orphan resources. |
masap
force-pushed
the
fix-vm-force-reset-policy
branch
from
19d7e94 to
1a556cf
Compare
Signed-off-by: Masashi Honma <masashi.honma@gmail.com>
masap
force-pushed
the
fix-vm-force-reset-policy
branch
from
1a556cf to
537e825
Compare
Vicente-Cheng
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
There are some fixes on
vm-force-reset-policyat 1.7. But the document does not have latest information.Solution:
Add latest information by this PR.
Reference: https://www.suse.com/c/suse-virtualization-node-failure-strategy/
Related Issue(s):
Test plan:
Additional documentation or context