Skip to content

Update evictionStrategy for imported VMs #956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
votdev wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update evictionStrategy for imported VMs #956

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions versioned_docs/version-v1.6/advanced/addons/vmimport.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,3 +243,30 @@ To address the issue, perform one of the following workarounds:
- Shut down the virtual machine before migrating it to Harvester
- In the `VirtualMachineImport` CRD spec, set the `forcePowerOff` field to `true`.
- Install VMware Tools or [open-vm-tools](https://knowledge.broadcom.com/external/article?legacyId=2073803).

##### Eviction strategy is not set
Copy link

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The heading capitalization is inconsistent with other headings in the same section. Other headings like "Source Virtual Machine Name Is Not RFC1123-Compliant" and "VMware-Based Virtual Machine Without VMware Tools Is Not Migrated" use title case with major words capitalized. This heading should be "Eviction Strategy Is Not Set" for consistency.

Suggested change
##### Eviction strategy is not set
##### Eviction Strategy Is Not Set

Copilot uses AI. Check for mistakes.

When importing virtual machines, the eviction strategy field is not configured, which subsequently prevents live migration of the virtual machine.
To fix this, please run the following command:
Comment on lines +249 to +250
Copy link

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The phrase "To fix this, please run the following command:" could be more consistent with the documentation style used in the previous known issue. Consider using a more formal and consistent phrasing such as "To address the issue, run the following command:" which matches the style of "To address the issue, perform one of the following workarounds:" used in the VMware Tools issue above.

Copilot uses AI. Check for mistakes.

```shell
kubectl patch VirtualMachine <vm-name> -n <namespace> --type=merge -p '{
"spec": {
"template": {
"spec": {
"evictionStrategy": "LiveMigrateIfPossible"
}
}
}
}'
```

To configure all incorrectly configured virtual machines at once, please use the following command:
Copy link

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The phrasing "To configure all incorrectly configured virtual machines" is redundant. Consider simplifying to "To configure all affected virtual machines at once" or "To update all virtual machines missing the eviction strategy" for better clarity and conciseness.

Suggested change
To configure all incorrectly configured virtual machines at once, please use the following command:
To update all virtual machines missing the eviction strategy at once, use the following command:

Copilot uses AI. Check for mistakes.

```shell
for vm in $(kubectl get VirtualMachine -A -o json | jq -r '.items[] | select(.spec.template.spec.evictionStrategy == null) | "\(.metadata.namespace):\(.metadata.name)"'); do \
kubectl patch VirtualMachine ${vm#*:} -n ${vm%:*} --type=merge -p '{"spec":{"template":{"spec":{"evictionStrategy":"LiveMigrateIfPossible"}}}}'; \
done
```
Comment on lines +264 to +270
Copy link

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation should clarify the prerequisites for running the bulk update command. The command requires jq to be installed, which may not be immediately obvious to all users. Consider adding a note that jq is required for the second command, or provide an alternative approach for users who don't have jq installed.

Copilot uses AI. Check for mistakes.

You need to reboot the virtual machine to apply the changes.
27 changes: 27 additions & 0 deletions versioned_docs/version-v1.7/advanced/addons/vmimport.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,3 +285,30 @@ To address the issue, perform one of the following workarounds:
- Shut down the virtual machine before migrating it to Harvester
- In the `VirtualMachineImport` CRD spec, set the `forcePowerOff` field to `true`.
- Install VMware Tools or [open-vm-tools](https://knowledge.broadcom.com/external/article?legacyId=2073803).

##### Eviction strategy is not set
Copy link

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The heading capitalization is inconsistent with other headings in the same section. Other headings like "Source Virtual Machine Name Is Not RFC1123-Compliant" and "VMware-Based Virtual Machine Without VMware Tools Is Not Migrated" use title case with major words capitalized. This heading should be "Eviction Strategy Is Not Set" for consistency.

Suggested change
##### Eviction strategy is not set
##### Eviction Strategy Is Not Set

Copilot uses AI. Check for mistakes.

When importing virtual machines, the eviction strategy field is not configured, which subsequently prevents live migration of the virtual machine.
To fix this, please run the following command:
Comment on lines +291 to +292
Copy link

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The phrase "To fix this, please run the following command:" could be more consistent with the documentation style used in the previous known issue. Consider using a more formal and consistent phrasing such as "To address the issue, run the following command:" which matches the style of "To address the issue, perform one of the following workarounds:" used in the VMware Tools issue above.

Copilot uses AI. Check for mistakes.

```shell
kubectl patch VirtualMachine <vm-name> -n <namespace> --type=merge -p '{
"spec": {
"template": {
"spec": {
"evictionStrategy": "LiveMigrateIfPossible"
}
}
}
}'
```

To configure all incorrectly configured virtual machines at once, please use the following command:
Copy link

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The phrasing "To configure all incorrectly configured virtual machines" is redundant. Consider simplifying to "To configure all affected virtual machines at once" or "To update all virtual machines missing the eviction strategy" for better clarity and conciseness.

Suggested change
To configure all incorrectly configured virtual machines at once, please use the following command:
To update all virtual machines missing the eviction strategy, run the following command:

Copilot uses AI. Check for mistakes.

```shell
for vm in $(kubectl get VirtualMachine -A -o json | jq -r '.items[] | select(.spec.template.spec.evictionStrategy == null) | "\(.metadata.namespace):\(.metadata.name)"'); do \
kubectl patch VirtualMachine ${vm#*:} -n ${vm%:*} --type=merge -p '{"spec":{"template":{"spec":{"evictionStrategy":"LiveMigrateIfPossible"}}}}'; \
done
```
Comment on lines +306 to +312
Copy link

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation should clarify the prerequisites for running the bulk update command. The command requires jq to be installed, which may not be immediately obvious to all users. Consider adding a note that jq is required for the second command, or provide an alternative approach for users who don't have jq installed.

Copilot uses AI. Check for mistakes.

You need to reboot the virtual machine to apply the changes.