Skip to content

Conversation

@ibrokethecloud
Copy link
Collaborator

PR helps better tracking of inventory and cluster resources by adding a mutating webhook in seeder. The webhook extracts userinfo from the authentication info and labels the same in cluster object.

The inventory and cluster controllers then ensure that this info is synced to the associated inventory object when a cluster is created/updated and cleaned from inventory when cluster is deleted

Related issue: harvester/harvester#7949

@ibrokethecloud ibrokethecloud force-pushed the mutating-webhook-implementation branch from 14451c8 to 1f270aa Compare March 27, 2025 05:41
FrankYang0529
FrankYang0529 previously approved these changes Apr 1, 2025
Copy link
Member

@FrankYang0529 FrankYang0529 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mutating webhook in seeder. The webhook extracts userinfo from the
authentication info and labels the same in cluster object.

The inventory and cluster controllers then ensure that this info is
synced to the associated inventory object when a cluster is
created/updated and cleaned from inventory when cluster is deleted

Signed-off-by: Gaurav Mehta <gaurav.mehta@suse.com>

fix up linter errors

Signed-off-by: Gaurav Mehta <gaurav.mehta@suse.com>
Copy link
Member

@starbops starbops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants