Wait VM becomes getable after triggering restore #1419
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Which issue(s) this PR fixes:
What this PR does / why we need it:
vm_checker.wait_getablebetweenapi_client.backups.restoreandvm_checker.wait_ip_addressesvm_checker.wait_ip_addressescallsapi_client.vms.startin the callback chain and will assert FAIL if target VM does not exist.api_client.backups.restoreneeds some time to communicate withbackup-targetto restore VM. So depends on the env., VM instance may not be created immediately.Special notes for your reviewer:
This is a quick fix.
IMO, coder tends to expect function
wait_XXXdoes some polling GET, thus some error-prone. To enhance, we may:create_AAA_and_wait_XXX.Additional documentation or context
Verification
Before (

harvester-runtests#61)After (

harvester-runtests#62)